Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(native-filters): refactor filter bar #13723

Merged
merged 10 commits into from
Mar 22, 2021
Merged

refactor(native-filters): refactor filter bar #13723

merged 10 commits into from
Mar 22, 2021

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented Mar 21, 2021 •
edited
Loading

SUMMARY

This PR refactor FilterBar code and files

  1. Split FilterBar code to utils/hooks
  2. Separate control values to different folder
  3. Separate cascade popover to different folder
  4. Refactor Dashboard builder to ts with using hooks and split it code to some files

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@simcha90 simcha90 changed the title refactor (native-fitlers): refactor filter bar refactor(native-filters): refactor filter bar Mar 21, 2021
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #13723 (cd68df9) into master (daefebb) will decrease coverage by 4.15%.
The diff coverage is 93.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13723      +/-   ##
==========================================
- Coverage   77.39%   73.23%   -4.16%     
==========================================
  Files         928      620     -308     
  Lines       47024    21943   -25081     
  Branches     5812     5818       +6     
==========================================
- Hits        36393    16070   -20323     
+ Misses      10488     5730    -4758     
  Partials      143      143
Flag Coverage Δ
cypress 56.52% <91.47%> (+0.07%) ⬆️
hive ?
javascript 63.39% <87.09%> (+0.25%) ⬆️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/dashboard/components/Dashboard.jsx 85.26% <ø> (ø)
...end/src/dashboard/components/StickyVerticalBar.tsx 100.00% <ø> (ø)
...end/src/dashboard/components/dnd/DragDroppable.jsx 97.29% <ø> (ø)
...Filters/FilterBar/FilterControls/FilterControl.tsx 100.00% <ø> (ø)
...nd/src/dashboard/containers/DashboardComponent.jsx 100.00% <ø> (ø)
...src/dashboard/components/DashboardBuilder/utils.ts 78.57% <78.57%> (ø)
...ts/nativeFilters/FilterBar/FilterControls/state.ts 80.00% <80.00%> (ø)
...oard/components/nativeFilters/FilterBar/Header.tsx 87.09% <87.09%> (ø)
...ilters/FilterBar/FilterControls/FilterControls.tsx 95.00% <95.00%> (ø)
...d/components/DashboardBuilder/DashboardBuilder.tsx 95.12% <95.12%> (ø)
... and 331 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daefebb...cd68df9. Read the comment docs.

villebro
villebro approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the the large added/removed files were functionally mostly unchanged.

superset-frontend/src/dashboard/components/dnd/DragDroppable.jsx Show resolved Hide resolved
@villebro villebro merged commit aa92c1e into apache:master Mar 22, 2021
@junlincc
Copy link
Member

junlincc commented Mar 23, 2021 •
edited
Loading

@simcha90
I looked at master, native filter is broken. filter can not be saved. could you take a look? thanks!

@villebro plz wait for QA, or product signoff to merge PR.

Screen.Recording.2021-03-23.at.1.42.33.PM.mov

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Mar 25, 2021
@junlincc junlincc mentioned this pull request Mar 30, 2021
Closed
This was referenced Mar 31, 2021
Merged
Merged
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@simcha90
refactor(native-filters): refactor filter bar (apache#13723)
2d53ba6 
* fix: fix removeing native filter

* fix: fix native-cross filters

* fix: fix native-cross filters

* fix: fix native-cross filters

* fix: fix function declaration

* refactor: before pull

* refactor: refactor filter bar

* chore: add lic

* lint: fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simcha90 @junlincc @villebro @mistercrunch